fix(immersive): cap cover so the layout fits 1080p without overlap#64
Conversation
Sub-bug C from #54: at 1080p (often 125 % DPI on Windows laptops the logical viewport is around 864 px), the immersive Now Playing view sized its cover at `min(60vh, 32rem)` — a 512 px square. Add the top bar, the title + artist block, the spectrum visualizer, the progress bar, the controls and the bottom padding and the layout overflowed the viewport, so the visualizer ended up overlapping the title and the artist line. Cap the cover to `min(45vh, 26rem)` (≈ 388 px at 1080p, 416 px max on tall screens) and trim the gap below it from `mb-8` to `mb-6`. The hero stays visually dominant on 4K monitors while leaving a ~200 px stack of room for the transport on a 1080p / 125 % DPI viewport.
📝 WalkthroughWalkthroughAjustement du dimensionnement du héros de couverture dans le lecteur fullscreen. La largeur maximale est réduite de ChangesAjustement du dimensionnement responsive du héros de couverture
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Sub-bug C of #54: in the immersive Now Playing view, the cover was sized at
min(60vh, 32rem)— a 512 px square. On a 1080p / 125 % DPI laptop the logical viewport is around 864 px tall; once the top bar, title + artist block, spectrum visualizer, progress bar, controls and bottom padding are stacked together, the layout overflowed the viewport and the visualizer ended up rendering on top of the metadata line.Fix
Cap the cover to
min(45vh, 26rem)(≈ 388 px at 1080p, 416 px max on tall screens) and trim the gap below it frommb-8tomb-6. The hero stays visually dominant on 4K monitors while leaving roughly 200 px of room for the transport stack on a 1080p / 125 % DPI viewport.Test plan
bun run typecheckbun run lintRelated
Bundles with #63 (sidebar 1080p) as part of the wider #54 polish — #54 also has sub-bugs D (Library density at 1080p) and E (README screenshots) still to address.
Summary by CodeRabbit