Skip to content

fix(ui): open cover/artist lightbox on single click #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
InstaZDLL merged 2 commits into from
May 19, 2026
Merged

fix(ui): open cover/artist lightbox on single click #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5fb43e4
fix(ui): open cover/artist lightbox on single click
InstaZDLL May 19, 2026
5ad6e9d
fix(deps): update typescript-eslint to version 8.59.4 and bump num-co…
InstaZDLL May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bun.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions src-tauri/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/components/layout/NowPlayingPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ export function NowPlayingPanel({ onNavigateToArtist }: NowPlayingPanelProps) {
<div className="p-6 space-y-6">
{/* Large artwork */}
<div
onDoubleClick={() => {
onClick={() => {
if (currentTrack.artwork_path) setIsLightboxOpen(true);
}}
Comment thread
InstaZDLL marked this conversation as resolved.
className={
Expand Down
2 changes: 1 addition & 1 deletion src/components/views/AlbumDetailView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ export function AlbumDetailView({
when the side lyrics panel is open. */}
<div className="flex items-start space-x-6">
<div
onDoubleClick={() => {
onClick={() => {
if (album.artwork_path) setIsLightboxOpen(true);
}}
Comment thread
InstaZDLL marked this conversation as resolved.
className={album.artwork_path ? "cursor-zoom-in" : undefined}
Expand Down
4 changes: 2 additions & 2 deletions src/components/views/ArtistDetailView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ export function ArtistDetailView({
<img
src={pictureSrc}
alt={artist.name}
onDoubleClick={() => setIsLightboxOpen(true)}
onClick={() => setIsLightboxOpen(true)}
Comment thread
InstaZDLL marked this conversation as resolved.
className="w-48 h-48 rounded-full object-cover shadow-lg cursor-zoom-in"
/>
) : (
Expand All @@ -268,7 +268,7 @@ export function ArtistDetailView({
</div>
)}
{/* The wrapper is pointer-events-none so the underlying <img>
keeps receiving onDoubleClick (lightbox); the inner button
keeps receiving onClick (lightbox); the inner button
re-enables pointer events for the small pencil hit area. */}
<div className="absolute right-2 bottom-2 pointer-events-none">
<button
Expand Down
Loading