fixes match statements to work with PositionProvider#1389
fixes match statements to work with PositionProvider#1389drinkmorewaterr merged 4 commits intoInstagram:mainfrom
Conversation
|
Hi @imsut! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
imsut
changed the title
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
meta-cla
bot
added
the
CLA Signed
drinkmorewaterr
left a comment
drinkmorewaterr
left a comment
There was a problem hiding this comment.
Thanks for doing this! 😁
LGTM, will merge once CI comes back green !
|
@drinkmorewaterr -- I'd like to try this fix. Is there a plan to cut a release v1.8.3? |
* add failing test * fix issue * fixes an issue with PositionProvider not working with case statement * remove comments --------- Co-authored-by: steve <steve@patreon.com>
3 participants
Summary
(This is a rebase of #1369)
Fixes #1322 where PositionProvider does not provide positions for whitespace. The issue seems to be that when there is no pattern for whitespace nodes during codegen, then they are not included in the position metadata.
Test Plan