chore: upgrade safe-settings to 2.1.19, harden workflow#13
Closed
nbrieussel wants to merge 1 commit intofix/workflow-permissionsfrom
Closed
chore: upgrade safe-settings to 2.1.19, harden workflow#13nbrieussel wants to merge 1 commit intofix/workflow-permissionsfrom
nbrieussel wants to merge 1 commit intofix/workflow-permissionsfrom
Conversation
- ubuntu-latest → ubuntu-24.04, add timeout-minutes: 30 (closes #4) - SAFE_SETTINGS_VERSION 2.1.17 → 2.1.19 (closes #5) - SHA-pin checkout ref comment for 2.1.19, npm install → npm ci (closes #8) - Update CLAUDE.md bug #4 note to reflect 2.1.19 is now running Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bundles three related workflow improvements to avoid merge conflicts (all touch the same file):
ubuntu-latest→ubuntu-24.04,npm install→npm ci, addtimeout-minutes: 30SAFE_SETTINGS_VERSION; picks up the probot v14 full-sync fix from upstream PR #949# pin: 6a8b6ae084987025f6c5de85e3cc6df140f64502comment on theref:line; the variable stays so Renovate can bump it automaticallyAlso updates
CLAUDE.mdbug #4 note to reflect that 2.1.19 is now running.Dependency
This PR is based on #10 (
fix/workflow-permissions) and must be merged after #10. Both touch.github/workflows/safe-settings-sync.yml; stacking here avoids conflicts.Dry-run checklist (to run manually before merge)
gh workflow run safe-settings-sync.yml --repo IntegratedDynamic/admin --ref chore/workflow-hardening-and-upgrade -f nop=truegh run list --repo IntegratedDynamic/admin --limit 3gh run view <run-id> --repo IntegratedDynamic/admin --log | grep "There are changes"Closes #4
Closes #5
Closes #8