Skip to content

Refactor dpnp.fix() to reuse dpnp.trunc internally #2722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vlad-perevezentsev merged 8 commits into from
Jan 19, 2026
Merged

Refactor dpnp.fix() to reuse dpnp.trunc internally #2722

vlad-perevezentsev merged 8 commits into from
Jan 19, 2026
+7 −278

Conversation

@vlad-perevezentsev
Copy link
Contributor

@vlad-perevezentsev vlad-perevezentsev commented Jan 15, 2026 •
edited
Loading

This PR rewrites dpnp.fix to reuse dpnp.trunc internally removing the backend implementation of dpnp.fix

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@vlad-perevezentsev vlad-perevezentsev self-assigned this Jan 15, 2026
@antonwolfy antonwolfy added this to the 0.20.0 release milestone Jan 15, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 15, 2026 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

antonwolfy
antonwolfy reviewed Jan 15, 2026
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Jan 15, 2026 •
edited
Loading

Array API standard conformance tests for dpnp=0.20.0dev1=py313h509198e_57 ran successfully.
Passed: 1229
Failed: 0
Skipped: 7

@coveralls
Copy link
Collaborator

coveralls commented Jan 15, 2026 •
edited
Loading

Coverage Status

coverage: 81.304% (-0.03%) from 81.337%
when pulling 11ec54a on use_tranc_in_fix_func
into 4d0462d on master.

antonwolfy
antonwolfy reviewed Jan 16, 2026
View reviewed changes
antonwolfy
antonwolfy approved these changes Jan 16, 2026
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vlad-perevezentsev, LGTM!

@vlad-perevezentsev vlad-perevezentsev merged commit 7b73f74 into master Jan 19, 2026
101 of 141 checks passed
@vlad-perevezentsev vlad-perevezentsev deleted the use_tranc_in_fix_func branch January 19, 2026 16:23
github-actions bot added a commit that referenced this pull request Jan 19, 2026
@github-actions
Refactor dpnp.fix() to reuse dpnp.trunc internally (#2722)
a40fe90 
This PR rewrites `dpnp.fix` to reuse `dpnp.trunc` internally removing
the backend implementation of `dpnp.fix` 7b73f74
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

@vlad-perevezentsev vlad-perevezentsev

Labels

None yet

Projects

None yet

Milestone

0.20.0 release

Development

Successfully merging this pull request may close these issues.

3 participants

@vlad-perevezentsev @coveralls @antonwolfy