Merged
Conversation
also fixes bugs related to the tests, and updates some functionality
Does not handle float conversion to integer types. Adapt hacks from NumPy source code instead
ndgrigorian
requested review from
antonwolfy,
jharlow-intel and
xaleryb
as code owners
Collaborator
Author
|
@jharlow-intel @antonwolfy there will need to be follow-up PRs in the future to fix more behavior edge cases |
antonwolfy
reviewed
Mar 19, 2026
antonwolfy
approved these changes
Mar 19, 2026
Collaborator
antonwolfy
left a comment
antonwolfy
left a comment
There was a problem hiding this comment.
Thank you @ndgrigorian, LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR vendors third party tests from NumPy to test
mkl_randomNumPy interfaceAlso updates a few functions for newer NumPy versions and fixes bugs, such as
np.nanas an argument