feat: Add object type filtering for delete membership in LDAP/AD provisioner #261
Open
tushyjw wants to merge 4 commits intoInternet2:GROUPER_5_BRANCHfrom
Open
feat: Add object type filtering for delete membership in LDAP/AD provisioner #261tushyjw wants to merge 4 commits intoInternet2:GROUPER_5_BRANCHfrom
tushyjw wants to merge 4 commits intoInternet2:GROUPER_5_BRANCHfrom
Conversation
feat: Add object type filter configuration for delete membership operations - Add deleteMembershipsObjectTypeFilter property to grouper-loader.base.properties - Enables filtering delete operations by object type (user, group, entity) - Positioned after main deleteMemberships flag with order 3550 - Includes dropdown UI configuration with validation options
…class support for object type filtering feat: Add configuration class support for object type filtering - Add deleteMembershipsObjectTypeFilter field to GrouperProvisioningConfiguration - Implement getter/setter methods for the new property - Add configuration loading in populateConfigurationFromProperties() - Enables Java code to access the object type filter setting
…iltering logic in delete membership feat: Implement object type filtering logic in delete membership - Add filter logic to isDeleteMembership() method - Apply filter early in decision process before other delete conditions - Return false when object type doesn't match configured filter - Access deleteMembershipsObjectTypeFilter from configuration
…dation for object type filter in delete membership feat: Add validation for object type filter in delete membership - Validate deleteMembershipsObjectTypeFilter values - Ensure only 'user', 'group', or 'entity' are allowed - Add error message for invalid filter values - Position validation after delete type checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature adds object type filtering to delete membership operations in the Grouper LDAP/AD provisioner, enabling administrators to selectively control which memberships get deleted based on their object type (user, group, or entity).
Changes Made
deleteMembershipsObjectTypeFilterconfiguration property with dropdown UIGrouperProvisioningBehavior.isDeleteMembership()methodBenefits
Configuration
The filter is configured via the new
deleteMembershipsObjectTypeFilterproperty with options:The filter is evaluated early in the delete decision process, allowing type-based exclusions before other delete conditions are applied.