Skip to content

Bump network and consensus for node-10.6.2 #1104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
palas merged 5 commits into from
Feb 11, 2026
Merged

Bump network and consensus for node-10.6.2 #1104

palas merged 5 commits into from
Feb 11, 2026
+30 −22

Conversation

@zliu41
Copy link
Member

@zliu41 zliu41 commented Feb 9, 2026 •
edited by palas
Loading

Changelog

- description: |
    Bumped `network` and `consensus`
  type:
    - maintenance
  projects:
    - cardano-api

@zliu41 zliu41 requested a review from coot February 9, 2026 16:15
@zliu41
Copy link
Member Author

zliu41 commented Feb 9, 2026

@palas What did you do previously to make CI green?

@palas
Copy link
Contributor

palas commented Feb 10, 2026

When I got that error in cli and node I updated the ghc version used for mingw compilation to 9.12

@palas palas force-pushed the zliu41/cardano-node-10.6.2 branch from a78ef14 to 8aa84f3 Compare February 10, 2026 19:49
@palas palas force-pushed the zliu41/cardano-node-10.6.2 branch 12 times, most recently from e710353 to d3a86c3 Compare February 10, 2026 23:04
@palas palas force-pushed the zliu41/cardano-node-10.6.2 branch from d3a86c3 to 67ee42e Compare February 10, 2026 23:06
@palas
Copy link
Contributor

palas commented Feb 11, 2026

@carbolymer, in order for the latest ouroboros libraries versions to compile to mingw32, I had to change the mingw32 compiler version to ghc9122. But that breaks cardano-rpc, as you know.

Is it ok if I disable the compilation of cardano-rpc for ghc >= 9.12 while #1098 is not ready?

Afterwards you just have to revert this commit: 67ee42e

carbolymer
carbolymer reviewed Feb 11, 2026
View reviewed changes
flake.nix
# Used for cross compilation, and so referenced in .github/workflows/release-upload.yml. Adapt the
# latter if you change this value.
crossCompilerVersion = "ghc967";
crossCompilerVersion = "ghc9122";
Copy link
Contributor

@carbolymer carbolymer Feb 11, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we switching to GH912 for cross-compilation? We are still building cardano-node using 9.6.7 so it is beneficial to have this in CI. Otherwise you will only catch windows cross-compilation issues at the integration stage in cardano-node.

carbolymer
carbolymer requested changes Feb 11, 2026
View reviewed changes
Copy link
Contributor

@carbolymer carbolymer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carbolymer, in order for the latest ouroboros libraries versions to compile to mingw32, I had to change the mingw32 compiler version to ghc9122. But that breaks cardano-rpc, as you know.

But o-c and o-n are both using GHC 9.6 on windows in CI without issues. What error does this solve?

carbolymer
carbolymer approved these changes Feb 11, 2026
View reviewed changes
Copy link
Contributor

@carbolymer carbolymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, this should be fine 😉

@palas
Copy link
Contributor

palas commented Feb 11, 2026

Ok, let me update the wasm cache and I'll merge this

palas
palas requested changes Feb 11, 2026
View reviewed changes
Copy link
Contributor

@palas palas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating the wasm cache, I'll merge when I am done

@palas palas added this pull request to the merge queue Feb 11, 2026
Merged via the queue into master with commit 42f6e7b Feb 11, 2026
29 checks passed
@palas palas deleted the zliu41/cardano-node-10.6.2 branch February 11, 2026 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carbolymer carbolymer carbolymer approved these changes

@palas palas palas approved these changes

@coot coot Awaiting requested review from coot

@dcoutts dcoutts Awaiting requested review from dcoutts dcoutts is a code owner

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350 Jimbo4350 is a code owner

@erikd erikd Awaiting requested review from erikd erikd is a code owner

@newhoggy newhoggy Awaiting requested review from newhoggy newhoggy is a code owner

@kevinhammond kevinhammond Awaiting requested review from kevinhammond kevinhammond is a code owner

@CarlosLopezDeLara CarlosLopezDeLara Awaiting requested review from CarlosLopezDeLara CarlosLopezDeLara is a code owner

@disassembler disassembler Awaiting requested review from disassembler disassembler is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zliu41 @palas @carbolymer