Conversation
Ryun1
commented
Feb 11, 2026
| # Returns the deposit amount in lovelace, or "null" if query fails | ||
| query_governance_deposit() { | ||
| # Check if cardano-cli is available | ||
| if ! command -v cardano-cli >/dev/null 2>&1; then |
Member
Author
There was a problem hiding this comment.
move this boilerplate to top of script
Ryun1
commented
Feb 11, 2026
| local deposit_amount | ||
| deposit_amount=$(query_governance_deposit) | ||
|
|
||
| # If deposit query failed, use null (JSON null, not string) |
Member
Author
There was a problem hiding this comment.
probably exit code 1, rather than using null
we wouldnt null in metadata in any cases
Ryun1
commented
Feb 11, 2026
|
|
||
| # Validate the JSON file against the schemas | ||
| schemas=("$TMP_SCHEMAS_DIR"/*-schema.json) | ||
|
|
Member
Author
There was a problem hiding this comment.
Suggested change
| # In the case where flags are used to not have any schemas download, exit with 1 |
Ryun1
commented
Feb 11, 2026
|
|
||
| deposit_return=$(jq -r '.body.onChain.depositReturnAddress' "$input_file") | ||
| check_field "depositReturnAddress" "$deposit_return" | ||
| deposit_return=$(jq -r '.body.onChain.reward_account' "$input_file") |
Member
Author
There was a problem hiding this comment.
add on-chain check to compare the metadata to on-chain state
Ryun1
commented
Feb 11, 2026
|
|
||
| deposit_return=$(jq -r '.body.onChain.depositReturnAddress' "$input_file") | ||
| check_field "depositReturnAddress" "$deposit_return" | ||
| deposit=$(jq -r '.body.onChain.deposit' "$input_file") |
Member
Author
There was a problem hiding this comment.
add on-chain check to compare the metadata to on-chain state
i.e. is the number matching the on-chain parameter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
List of changes