Replace Dictionary with HashSet#2033
Merged
slozier merged 3 commits intoIronLanguages:mainfrom Apr 3, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the equivalent of IronLanguages/dlr#322 on the IronPython side. Maybe
HashSetdid not exist yet when this code was written.It is a very opportunistic and straightforward change. Perhaps more possibilities for optimizations exist. One such place is
FunctionCode.cs, which contains classPythonDebuggingPayload.TracingWalker. It defines several dictionaries where the value isbool. They look like sets, if the value is always,true,false, or ignored. Maybe this can be simplified somehow or maybe it is unfinished work, but will require more code analysis than what I am doing here for such a mechanical upgrade. Besides, this seems to be used only for debugging/tracing, when performance is not that important.