Improve documentation#532
Conversation
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThis PR restructures the JADE Sphinx documentation by elevating Benchmarks to top-level navigation, reorganizing the developer guide with new WebApp subsection, creating comprehensive add-benchmark workflow documentation, and consolidating About/publications content. The old flat documentation/benchmarks.rst structure is removed. ChangesDocumentation Structure and Navigation Reorganization
🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/source/about/about_idx.rst`:
- Line 1: The Sphinx target label "benchmarks" is duplicated and should be
renamed to a unique label (e.g., "about_benchmarks" or "benchmarks_about") to
avoid :ref: resolution conflicts; update the label in this file (the top
directive currently ".. _benchmarks:") to the new unique name and search/update
any cross-references that point to "benchmarks" to use the new label so all
links resolve correctly.
- Around line 3-5: Rename the page heading from "Benchmarks" to "About" in the
about_idx RST file (the page wired as about/about_idx) by replacing both the
overline and the title text so the visual header reads "About" and ensure the
underline/overline length matches the new title length (adjust the row of #
characters accordingly) so the reStructuredText heading stays valid.
In `@docs/source/dev/webapp.rst`:
- Line 95: Fix the typo in the user-facing docs by replacing the word
“benchmarls” with “benchmarks” in the sentence that currently reads "forces the
plot always to be C/E (ratio). This is sometimes useful for some of the
experimental benchmarls where absolute values are not that important." Update
that exact phrase so the docs display the correct spelling "benchmarks".
- Line 76: The "grouped_bar options" link text is malformed and may 404; update
the link target so it matches Plotly's correct URL pattern used elsewhere —
replace the existing `grouped_bar options
<https://plotly.com/python-api-reference/generated/plotly.express.bar>`_ anchor
with the correct Plotly reference URL for grouped bar options (the same style
used for other Plotly links) so the `grouped_bar options` link points to the
proper plotly.express.bar documentation page.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: ad355923-3672-4334-8d4f-93ca23055ae3
⛔ Files ignored due to path filters (4)
docs/source/benchmarks/computational_overview.csvis excluded by!**/*.csvdocs/source/benchmarks/exp_overview.csvis excluded by!**/*.csvdocs/source/documentation/computational_overview.csvis excluded by!**/*.csvdocs/source/documentation/exp_overview.csvis excluded by!**/*.csv
📒 Files selected for processing (43)
docs/source/about/LICENSE.rstdocs/source/about/about_idx.rstdocs/source/about/contributors.rstdocs/source/about/publications.rstdocs/source/benchmarks/benchdesc/ISIS-800MeV-C.rstdocs/source/benchmarks/benchdesc/aspis/aspis-fe88.rstdocs/source/benchmarks/benchdesc/aspis/aspis-pca-replica.rstdocs/source/benchmarks/benchdesc/cmodel.rstdocs/source/benchmarks/benchdesc/fng/fng-blk.rstdocs/source/benchmarks/benchdesc/fng/fng-hcpb.rstdocs/source/benchmarks/benchdesc/fng/fng-sddr.rstdocs/source/benchmarks/benchdesc/fng/fng-sic.rstdocs/source/benchmarks/benchdesc/fng/fng-ss.rstdocs/source/benchmarks/benchdesc/fng/fng-w.rstdocs/source/benchmarks/benchdesc/fng/tud-fng.rstdocs/source/benchmarks/benchdesc/fng/tud-w.rstdocs/source/benchmarks/benchdesc/fns-tof.rstdocs/source/benchmarks/benchdesc/icbep_disclaimer.rstdocs/source/benchmarks/benchdesc/ippe/ippe_cf.rstdocs/source/benchmarks/benchdesc/ippe/ippe_dt.rstdocs/source/benchmarks/benchdesc/iter1d.rstdocs/source/benchmarks/benchdesc/itercylSDDR.rstdocs/source/benchmarks/benchdesc/oktavian.rstdocs/source/benchmarks/benchdesc/rcr/rcr-fe+ni.rstdocs/source/benchmarks/benchdesc/rcr/rcr-ss.rstdocs/source/benchmarks/benchdesc/simptokamak.rstdocs/source/benchmarks/benchdesc/sinbad_disclaimer.rstdocs/source/benchmarks/benchdesc/sphere.rstdocs/source/benchmarks/benchdesc/sphereSDDR.rstdocs/source/benchmarks/benchdesc/tbm.rstdocs/source/benchmarks/benchdesc/tiara.rstdocs/source/benchmarks/benchdesc/tud-fe.rstdocs/source/benchmarks/benchmark_idx.rstdocs/source/benchmarks/computational.rstdocs/source/benchmarks/experimental.rstdocs/source/benchmarks/overview.rstdocs/source/dev/dev_idx.rstdocs/source/dev/insertbenchmarks.rstdocs/source/dev/webapp.rstdocs/source/documentation/benchmarks.rstdocs/source/documentation/docu_idx.rstdocs/source/index.rstdocs/source/usage/usage_idx.rst
💤 Files with no reviewable changes (2)
- docs/source/documentation/docu_idx.rst
- docs/source/documentation/benchmarks.rst
|
|
||
| * `step options <https://plotly.com/python-api-reference/generated/plotly.express.line.html>`_ from plotly API reference | ||
| * `scatter options <https://plotly.com/python-api-reference/generated/plotly.express.scatter.html>`_ from plotly API reference. | ||
| * `grouped_bar options <https://plotly.com/python-api-reference/generated/plotly.express.bar>`_ from plotly API reference. |
There was a problem hiding this comment.
Fix the grouped bar Plotly reference URL.
The grouped_bar options link appears malformed compared to the other Plotly links and may 404 in some contexts.
Suggested diff
- * `grouped_bar options <https://plotly.com/python-api-reference/generated/plotly.express.bar>`_ from plotly API reference.
+ * `grouped_bar options <https://plotly.com/python-api-reference/generated/plotly.express.bar.html>`_ from plotly API reference.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| * `grouped_bar options <https://plotly.com/python-api-reference/generated/plotly.express.bar>`_ from plotly API reference. | |
| * `grouped_bar options <https://plotly.com/python-api-reference/generated/plotly.express.bar.html>`_ from plotly API reference. |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/source/dev/webapp.rst` at line 76, The "grouped_bar options" link text
is malformed and may 404; update the link target so it matches Plotly's correct
URL pattern used elsewhere — replace the existing `grouped_bar options
<https://plotly.com/python-api-reference/generated/plotly.express.bar>`_ anchor
with the correct Plotly reference URL for grouped bar options (the same style
used for other Plotly links) so the `grouped_bar options` link points to the
proper plotly.express.bar documentation page.
alexvalentine94
left a comment
There was a problem hiding this comment.
One minor comment to consider.
There was a problem hiding this comment.
Did we also add to the docs that this table should be updated by the user.
fix #519
fix #463
Summary by CodeRabbit
Documentation