Skip to content

Simple tokamak histogram plots#535

Merged
dodu94 merged 3 commits into
JADE-V-V:developingfrom
jude-moo:SimpleTokamakHistogramPlots
May 21, 2026
Merged

Simple tokamak histogram plots#535
dodu94 merged 3 commits into
JADE-V-V:developingfrom
jude-moo:SimpleTokamakHistogramPlots

Conversation

@jude-moo
Copy link
Copy Markdown
Collaborator

This pull request includes the changes required to implement histogram plots into the atlas file of the Simple_Tokamak benchmark.

The following changes were made:

  • Implementation of 'shorten_x_name', in order to generate a plot that looked sensible. Previously the second subplot was cutting off the x_labels.
  • Updated the documentation to reflect the addition of shorten_x_name to the the plot_ars for the bar plot
  • line 893, was added so that if the total number of bins is exactly divisible by max_groups, previously it would have created an additional subplot that was empty.
  • Updated the atlas yaml file for the simple tokamak to include these new plots.
image

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 21, 2026

Warning

Rate limit exceeded

@jude-moo has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 45 minutes and 8 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 860fabdd-d470-41e9-872f-19fae8eb18e9

📥 Commits

Reviewing files that changed from the base of the PR and between 398d398 and eadc4c2.

📒 Files selected for processing (3)
  • docs/source/dev/pp_gallery.rst
  • src/jade/post/plotter.py
  • src/jade/resources/default_cfg/benchmarks_pp/atlas/Simple_Tokamak.yaml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
src/jade/post/plotter.py 94.24% <100.00%> (+0.12%) ⬆️

... and 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dodu94 dodu94 merged commit daff5ec into JADE-V-V:developing May 21, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature request] - Add heating histogram plots in Simple Tokamak benchmark

2 participants