Conversation
merge into lroc branch
…nd lowerleft swapped
garydoranjr
left a comment
There was a problem hiding this comment.
@Emmy-D Thanks a lot for making these changes, looks good! I made a bunch of minor comments.
One bigger question is about which additional files to include with this software. I think we should probably exclude any LROC-specific scripts that were used for the LROCnet project, since those will not be needed by most folks who download and install this software. Likewise, it might be good to exclude the inputs and inputs_mini directories (and corresponding examples in the README), since these seem specific to the LROCnet project or to the MLIA/JPL computing environments. I think these would be better to include in a separate repository that hosts the code for that project. Let me know what you think and whether you want to discuss at all.
…Added unit tests for passing in a parameter for downsampling, and added exception tests
Additions to the code include: