Self-enable Pages in docs.yml (avoid bootstrap race)#72
Merged
Conversation
Pass `enablement: true` to actions/configure-pages@v5 so the first push to main on a fresh clone or fork auto-creates the Pages site rather than failing with "Get Pages site failed: Not Found". This was the race we hit between the PR #69 merge and the manual settings toggle in this repo, and would otherwise bite anyone forking the project. No behaviour change for already-enabled repos: configure-pages short-circuits when the site exists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass `enablement: true` to `actions/configure-pages@v5` so the first push to `main` on a fresh clone or fork auto-creates the Pages site rather than failing with "Get Pages site failed: Not Found".
This is the race that bit us on the PR #69 merge run: the workflow tried to deploy before the repo-level Pages toggle had been flipped. Subsequent runs went green after the manual settings change, but the next person to fork or re-clone would hit the same wall.
The action's own error message explicitly recommends this parameter:
Behaviour
One-line workflow change plus a comment explaining why. No effect on Python CI or docs build.