This repository was archived by the owner on Mar 9, 2020. It is now read-only.
Open
Conversation
…ass. Added Sample_ErrorBars as an example of how to use with data to allow for an XY scatter example once that is done.
…xing inability to delete error bars once they have been added.
Comment on lines
+267
to
+275
| case eErrorBarValueType.FixedValue: | ||
| value = 0.1; | ||
| break; | ||
| case eErrorBarValueType.Percentage: | ||
| value = 5; | ||
| break; | ||
| case eErrorBarValueType.StandardDeviation: | ||
| value = 1.0; | ||
| break; |
There was a problem hiding this comment.
Unless I'm missing something, any of these 3 assignments will overwrite whatever value is retrieved by GetXmlNodeDoubleNull.
Consider rewriting this setter like this or similar:
double defaultValue;
switch (ValueType)
{
case eErrorBarValueType.CustomErrorBars:
throw new Exception("Error bar value is not valid for Custom Error Bars, use PlusAddress and MinusAddress");
case eErrorBarValueType.StandardError:
throw new Exception("Error bar value is not valid for Standard Error");
case eErrorBarValueType.FixedValue:
defaultValue = 0.1;
break;
case eErrorBarValueType.Percentage:
defaultValue = 5;
break;
case eErrorBarValueType.StandardDeviation:
defaultValue = 1.0;
break;
}
return GetXmlNodeDoubleNull(_errorBarValuePath) ?? defaultValue;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created ExcelChartErrorBar class that implements all functionality documented.
Added ExcelChartErrorBar to:
Automatically adds error bars when first accessed, Delete function available to remove each error bar if necessary.
Also fixed a bug in ExcelChartSeries which failed to recreate the series as type ExcelBarChartSerie when loading a bar chart in. Found when testing my example.
Created Sample_ErrorBars that shows the functionality in action for the three chart types.
Would be great to get this merged in and into a new version as I require this functionality for a project I am working on and is missing from the latest NuGet package.