Conversation
There was a problem hiding this comment.
Pull request overview
Implements the initial login page UI and introduces a small set of reusable “common” UI components in the web app, along with @/ path alias support for simpler imports.
Changes:
- Add common components:
Button,InputField,CheckboxField,TextButton(+ barrel exports) - Build the login page layout/styling using the new components
- Configure
@/path alias in Vite + TypeScript, and adjust UI GlobalStyles body layout
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/ui/src/GlobalStyles.tsx | Removes body flex-centering; sets body width to support full-width layouts |
| apps/web/vite.config.ts | Adds @ alias (currently uses __dirname) |
| apps/web/tsconfig.app.json | Adds TS baseUrl + paths mapping for @/* |
| apps/web/src/pages/LoginPage/LoginPage.tsx | Replaces placeholder login markup with composed form UI |
| apps/web/src/pages/LoginPage/LoginPage.styled.ts | Adds split background + form layout styling |
| apps/web/src/components/common/index.ts | Exports new common components from the common barrel |
| apps/web/src/components/common/Button/index.ts | Button barrel export |
| apps/web/src/components/common/Button/Button.tsx | Reusable button component with optional width prop |
| apps/web/src/components/common/Button/Button.styled.ts | Button styling |
| apps/web/src/components/common/InputField/index.ts | InputField barrel export |
| apps/web/src/components/common/InputField/InputField.tsx | Labeled input component |
| apps/web/src/components/common/InputField/InputField.styled.ts | InputField styling |
| apps/web/src/components/common/CheckboxField/index.ts | CheckboxField barrel export |
| apps/web/src/components/common/CheckboxField/CheckboxField.tsx | Labeled checkbox component |
| apps/web/src/components/common/CheckboxField/CheckboxField.styled.ts | CheckboxField styling |
| apps/web/src/components/common/TextButton/index.ts | TextButton barrel export |
| apps/web/src/components/common/TextButton/TextButton.tsx | Anchor-like text button component |
| apps/web/src/components/common/TextButton/TextButton.styled.ts | TextButton styling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull requests
작업 내용
공통 컴포넌트들을 구현했습니다.
Button : 로그인 버튼 등 전반적으로 사용되는 버튼 컴포넌트입니다.
InputField : 레이블과 input을 함께 묶어둔 컴포넌트입니다.
CheckboxField : 레이블과 체크박스를 함께 묶어둔 컴포넌트입니다.
TextButton : 텍스트 형식의 버튼 컴포넌트입니다. ( 태그와 동일)
로그인 페이지를 구현했습니다.
참고 사항
아직 와이어프레임 단계라서 컴포넌트 위주로 작업했습니다.
컴포넌트 import에서 사용할 수 있도록 path alias를 설정했습니다.
문법이나 스타일 등 이상하거나 잘못 작성한 부분이 있으면 편하게 알려주시면 감사하겠습니다.
화면 구성
Check List
이슈