Skip to content

fix: flaky Cancellation_Observed test — use pre-cancelled token #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JerrettDavis merged 2 commits into from
Mar 27, 2026
Merged

fix: flaky Cancellation_Observed test — use pre-cancelled token #147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
375843c
fix: flaky Cancellation_Observed test — use pre-cancelled token
JerrettDavis Mar 27, 2026
2acad85
fix: flaky Observer test — add 30s timeout instead of blocking Wait()
JerrettDavis Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions test/PatternKit.Generators.Tests/ObserverGeneratorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,8 @@ public static async System.Threading.Tasks.Task<string> Run()
var demoType = asm.GetType("PatternKit.Examples.Generators.Demo");
var runMethod = demoType!.GetMethod("Run");
var task = (System.Threading.Tasks.Task<string>)runMethod!.Invoke(null, null)!;
task.Wait();
if (!task.Wait(TimeSpan.FromSeconds(30)))
throw new TimeoutException("Demo.Run() did not complete within 30 seconds.");
var result = task.Result;
Assert.Equal("AsyncHandler:42", result);
}
Expand Down Expand Up @@ -629,7 +630,7 @@ public static async System.Threading.Tasks.Task<string> Run()
evt.Publish(new Temperature(10));

// Wait deterministically for async handler to complete
await tcs.Task.WaitAsync(System.TimeSpan.FromSeconds(5));
await tcs.Task.WaitAsync(System.TimeSpan.FromSeconds(30));

return string.Join("|", log);
}
Expand All @@ -655,7 +656,8 @@ public static async System.Threading.Tasks.Task<string> Run()
var demoType = asm.GetType("PatternKit.Examples.Generators.Demo");
var runMethod = demoType!.GetMethod("Run");
var task = (System.Threading.Tasks.Task<string>)runMethod!.Invoke(null, null)!;
task.Wait();
if (!task.Wait(TimeSpan.FromSeconds(30)))
throw new TimeoutException("Demo.Run() did not complete within 30 seconds.");
var result = task.Result;

// Both handlers should have been invoked
Expand Down
6 changes: 4 additions & 2 deletions test/PatternKit.Tests/Behavioral/AsyncTemplateMethodTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,10 @@ public Task Serializes_When_Synchronized()
[Fact]
public async Task Cancellation_Observed()
{
var template = new SampleAsyncTemplate(delayMs: 100);
using var cts = new CancellationTokenSource(10);
// Use a long delay with a pre-cancelled token to avoid timing races
var template = new SampleAsyncTemplate(delayMs: 5000);
using var cts = new CancellationTokenSource();
cts.Cancel(); // pre-cancel so cancellation is immediate and deterministic

// Assert.ThrowsAnyAsync verifies that OperationCanceledException or derived types are thrown
await Assert.ThrowsAnyAsync<OperationCanceledException>(
Expand Down
Loading