Draft
Conversation
* Moves data loading to DwarfManager and moves the old data loading to a legacy package. We only support loading for SQLite in order to allow data conversions to the new format. * Players are now fully referenced by UUID and no longer a separately stored player ID * MySQL support is removed * Removed config options for configuring MySQL and SQLite * SQLite .db file is no longer included in the plugin and will no longer be copied or created * Moved various data managers to the data package * Placeholder and output classes were moved to a util package * Level Up commands now listen to the LevelUpEvent listener and were moved to DwarfListener instead of being called from the DwarfCraft class. * Various cleanups to imports and logging
3 tasks
Fixed an issue where specifying "all" for a skill id when using the set_skill command no longer worked
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an extensive rework and change set to help modernize DwarfCraft's data system. Please reference issue #96 for the full details and scope of the rework. Reworking skills and effects are not in the scope of this PR. The goal is to move fully to more modern and human readable data formats that server admins can not only more easily manage but can also be more easily developed as Minecraft updates and evolves.