refactor: EXPOSED-454 add execute alter statements log on createMissingTablesAndColumns function#2166
Open
hungrytech wants to merge 1 commit intoJetBrains:mainfrom
Open
Conversation
hungrytech
changed the title
hungrytech
changed the title
hungrytech
changed the title
hungrytech
force-pushed
the
add-logging-on-alterstatement
branch
from
d51639f to
ffbc611
Compare
|
Fix #800 issue |
joc-a
reviewed
Jul 26, 2024
| addMissingColumnsStatements(tables = tables, withLogs) | ||
| } | ||
| logTimeSpent("Executing alter table statements", withLogs) { | ||
| alterStatements.forEach { exposedLogger.info("Alter table statements to execute - $it") } |
Contributor
There was a problem hiding this comment.
This would print "Alter table statements to execute" next to each ALTER statement.
You could also call addLogger(StdOutSqlLogger) in your transaction before calling SchemaUtils.createMissingTablesAndColumns and that would log the ALTER statements (and all other SQL statements being executed). How about doing that instead of this?
Author
There was a problem hiding this comment.
@joc-a
Thank you for the review.
As you mentioned, developers need to be aware that they must include addLogger(StdOutSqlLogger) in the transaction block. Since the ALTER command modifies the table, how about logging based on the value of the withLogs flag?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EXPOSED-454