Update InListOps.kt#2261
Open
GeorgCantor wants to merge 1 commit intoJetBrains:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary of the change: These changes improve both performance and readability while maintaining the original functionality of the code.
Detailed description:
Single Check for Iterator: We store the result of iterator.hasNext() in hasElements to avoid multiple calls.
Streamlined Column Type Handling: We use columnTypes.size instead of singleOrNull() for clarity and efficiency.
Helper Function for Operator Appending: The appendOperator function reduces redundancy in appending SQL operators based on whether it's an IN or NOT IN operation.
Concise Empty List Handling: The handling of an empty list is more straightforward, directly returning after appending the appropriate boolean value.
Type of Change
Please mark the relevant options with an "X":
Updates/remove existing public API methods:
Affected databases:
Checklist
Related Issues