fix: Enable column type change migration for PostgreSQL #2441#2715
Open
shinseongsu wants to merge 1 commit intoJetBrains:mainfrom
Open
fix: Enable column type change migration for PostgreSQL #2441#2715shinseongsu wants to merge 1 commit intoJetBrains:mainfrom
shinseongsu wants to merge 1 commit intoJetBrains:mainfrom
Conversation
- Add supportsColumnTypeChange = true to PostgreSQLDialect - Add test case for column type change migration - Update API declarations Fixes JetBrains#2441 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Member
|
Hi @shinseongsu Apologies for the delay on addressing this PR. Everything you've mentioned makes sense. Since it seems In the meantime, please consider changing this flag's value globally on your end, if you haven't already done so: Database.connect(
url = "...",
databaseConfig = DatabaseConfig {
explicitDialect = object : PostgreSQLDialect() {
override val supportsColumnTypeChange: Boolean = true
}
}
) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2441
Description
Summary of the change: Enable PostgreSQL to correctly detect and generate migration statements when a column's data type is modified.
Detailed description:
Why: The generateMigrationScript function for PostgreSQL was returning an empty file when only a column's data type was changed (e.g., from VARCHAR to TEXT). This occurred because supportsColumnTypeChange was not enabled in the PostgreSQLDialect class, causing the migration utility to skip type change detection entirely.
What:
How:
Type of Change
Please mark the relevant options with an "X":
Updates/remove existing public API methods:
Affected databases:
Checklist
Related Issues
Fixes #2441