Add option to check permissions with toggle #361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
Oh, gross, locally the move + documentation addition commits looked fine in my IDE, but it looks like git had different ideas. I guess I'll remake the commits to separate the docs from the API promotion to see if that'll fix it. |
Jikoo
force-pushed
the
dev/check-perm-in-toggle
branch
from
d4faa61 to
3203896
Compare
Owner
Author
|
The view still doesn't seem entirely correct (and I missed rolling back a hunk when pushing the move) but oh well. GitHub might be doing a flat diff when displaying it rather than a full history check. I usually squash and merge, so I guess that'd be the expected result anyway. Needs testing still. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #359 (comment)