Remove strings from functions where data is in key/value format#12
Open
kcranky wants to merge 8 commits intoJoeyStrandnes:masterfrom
Open
Remove strings from functions where data is in key/value format#12kcranky wants to merge 8 commits intoJoeyStrandnes:masterfrom
kcranky wants to merge 8 commits intoJoeyStrandnes:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch simplifies GET requests that return key/value pairs.
Further discussion can be found at Issue #7
Added:
KVPairandKVReturnvoid getKVPairs(String const URL, KVReturn &data);that takes in an API endpoint and a KVReturn struct. This means there is only one function to maintain for any API endpoint that returns simple key/value pairs.getKVPairs!)Modified:
getProjecttogetProjectsandgetWorkspacetogetWorkspaces. This is so that pre-existing users of the library are "forced" to take note of the change, as it is not backwards compatible.getProjectandgetWorkspace? This is all up to you though of course, just listing my thoughts.Verification: