Skip to content

Fix tracking URI to explicitly append /api to map to REST route #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pebeto merged 2 commits into from
Mar 22, 2026
Merged

Fix tracking URI to explicitly append /api to map to REST route #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
beed7c7
Fix tracking URI to explicitly append /api to map to REST route
aryawadhwa Mar 19, 2026
84e9fce
fix: update tests to expect /api appended to tracking URI
aryawadhwa Mar 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/types/mlflow.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,11 @@ struct MLFlow
apiroot = ENV["MLFLOW_TRACKING_URI"]
end

# Automatically append /api to the tracking URI if missing to match standard MLflow REST paths.
if !endswith(apiroot, "/api") && !endswith(apiroot, "/api/")
apiroot = endswith(apiroot, "/") ? apiroot * "api" : apiroot * "/api"
end

if haskey(ENV, "MLFLOW_TRACKING_USERNAME")
@warn "The provided username will be ignored as MLFLOW_TRACKING_USERNAME is set."
username = ENV["MLFLOW_TRACKING_USERNAME"]
Expand Down
24 changes: 22 additions & 2 deletions test/types/mlflow.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

instance = MLFlow("test", 2.0, Dict(), nothing, nothing)

@test instance.apiroot == "test"
@test instance.apiroot == "test/api"
@test instance.apiversion == 2.0
@test instance.headers == Dict()
@test isnothing(instance.username)
Expand All @@ -20,7 +20,7 @@

instance = MLFlow("test")

@test instance.apiroot == "test"
@test instance.apiroot == "test/api"
@test instance.apiversion == 2.0
@test instance.headers == Dict()
@test isnothing(instance.username)
Expand Down Expand Up @@ -71,4 +71,24 @@
@test_throws ErrorException MLFlow(; username="test", password="test",
headers=Dict("Authorization" => "Basic $encoded_credentials"))
end

@testset "appending /api to tracking uri" begin
delete!(ENV, "MLFLOW_TRACKING_URI")

instance_no_slash = MLFlow("https://dagshub.com/user/repo.mlflow")
@test instance_no_slash.apiroot == "https://dagshub.com/user/repo.mlflow/api"

instance_with_slash = MLFlow("https://dagshub.com/user/repo.mlflow/")
@test instance_with_slash.apiroot == "https://dagshub.com/user/repo.mlflow/api"

instance_already_api = MLFlow("https://dagshub.com/user/repo.mlflow/api")
@test instance_already_api.apiroot == "https://dagshub.com/user/repo.mlflow/api"

instance_already_api_slash = MLFlow("https://dagshub.com/user/repo.mlflow/api/")
@test instance_already_api_slash.apiroot == "https://dagshub.com/user/repo.mlflow/api/"

if !isnothing(mlflow_tracking_uri)
ENV["MLFLOW_TRACKING_URI"] = mlflow_tracking_uri
end
end
end
Loading