Add compat for ChainRulesCore v2#1339
Open
JamesWrigley wants to merge 1 commit intoJuliaArrays:masterfrom
Open
Add compat for ChainRulesCore v2#1339JamesWrigley wants to merge 1 commit intoJuliaArrays:masterfrom
JamesWrigley wants to merge 1 commit intoJuliaArrays:masterfrom
Conversation
This was referenced Mar 29, 2026
Author
|
Nightly failures are unrelated, they seem to be because #1112 has become out-of-date. |
Collaborator
|
There seems to be no ChainRulesCore.jl v2 tagged though? I think we shouldn't merge this until ChainRulesCore v2 is fully released and tagged. |
Author
|
Yeah that's fine, I'll hack around it for now 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See JuliaDiff/ChainRulesCore.jl#703. Tested manually by
deving v2.