Open
Conversation
With no node mutation, it is unclear why this is mutable (which costs some extra loads), though the recursion forces this to the heap regardless. But singleton struct Empty needs to be non-mutable now for correctness
The multi-replace method is being added in JuliaLang/julia#40484
Allocating strings with json character-by-character with ""+c+c+… is bad style, and this was not handling \u correctly either. We could make strcat a separate micro-benchmark, but it is not a particularly interesting test case currently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
on master
on PR