Skip to content

support negative k for k-subsets#63

Open
stev47 wants to merge 3 commits intoJuliaCollections:masterfrom
stev47:fix-subsets
Open

support negative k for k-subsets#63
stev47 wants to merge 3 commits intoJuliaCollections:masterfrom
stev47:fix-subsets

Conversation

@stev47
Copy link

@stev47 stev47 commented Aug 7, 2019

We have binomial(n, k)=0 for k<0 and k>n.
This makes subsets comply accordingly instead of creating wrong iterators or throwing errors.

@codecov-io
Copy link

codecov-io commented Aug 7, 2019

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 67.82%. Comparing base (8a26e26) to head (c43cd24).
⚠️ Report is 121 commits behind head on master.

Files with missing lines Patch % Lines
src/IterTools.jl 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
+ Coverage   67.57%   67.82%   +0.25%     
==========================================
  Files           1        1              
  Lines         256      258       +2     
==========================================
+ Hits          173      175       +2     
  Misses         83       83              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants