fix(jh): set correct auth when server name is juliahub#15
Merged
thelonewolf1603 merged 3 commits intomainfrom Feb 12, 2026
Merged
fix(jh): set correct auth when server name is juliahub#15thelonewolf1603 merged 3 commits intomainfrom
thelonewolf1603 merged 3 commits intomainfrom
Conversation
vdayanand
requested changes
Feb 6, 2026
auth.go
Outdated
| func deviceFlow(server string) (*TokenResponse, error) { | ||
| var authServer string | ||
| if server == "juliahub.com" { | ||
| if server == "juliahub.com" || server == "juliahub.juliahub.com" { |
Contributor
Author
There was a problem hiding this comment.
so if you add a server name e.g. custom , it will be converted to custom.juliahub.com. so if someone types only juliahub that will be converted to juliahub.juliahub.com
Member
There was a problem hiding this comment.
As discussed in call, better to move this check part of normalizeServername just to be clean and clear
Contributor
Author
There was a problem hiding this comment.
updated in normalizeServer itself, seems much clearer now
vdayanand
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #4