Adjust to method table changes#645
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #645 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 9 11 +2
Lines 1556 1593 +37
======================================
- Misses 1556 1593 +37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Seems like TypedSyntax is also broken through MethodAnalysis.jl. For this one though, the fix isn't as obvious because it used to access the method table from |
aviatesk
left a comment
There was a problem hiding this comment.
it used to access the method table from MethodList, and AFAIU it's no longer possible to do so.
So it seems that we need to change the fundamental implementation strategy of MethodAnalysis?
|
From what I understand, the method table was accessed for its backedges, and now these must be retrieved by other means. We now have them available via |
|
This should fix it: timholy/MethodAnalysis.jl#52 |
|
I don't see any downsides in merging this now, so we can have it part of the manual release. Hopefully the MethodAnalysis PR will get merged in a reasonable time frame so the TypedSyntax tests don't remain broken for too long. |
fT.name.mt.namewas replaced byfT.name.singletonnamein JuliaLang/julia#58131, which caused a breakage.