Skip to content

Mooncake 0.5.25 compat#988

Draft
sunxd3 wants to merge 3 commits intoJuliaDiff:mainfrom
sunxd3:sunxd/fix-mooncake-friendly-tangents
Draft

Mooncake 0.5.25 compat#988
sunxd3 wants to merge 3 commits intoJuliaDiff:mainfrom
sunxd3:sunxd/fix-mooncake-friendly-tangents

Conversation

@sunxd3
Copy link
Copy Markdown

@sunxd3 sunxd3 commented Apr 4, 2026

An attempt at addressing #986.

Feel free to make any edits or take over!

@sunxd3 sunxd3 requested a review from gdalle as a code owner April 4, 2026 14:47
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 4, 2026

Codecov Report

❌ Patch coverage is 11.11111% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.77%. Comparing base (a5ecbe0) to head (8235e6c).

Files with missing lines Patch % Lines
...e/ext/DifferentiationInterfaceMooncakeExt/utils.jl 12.50% 7 Missing ⚠️
...ifferentiationInterface/test/Back/Mooncake/test.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #988      +/-   ##
==========================================
- Coverage   98.21%   96.77%   -1.44%     
==========================================
  Files         135      135              
  Lines        8000     8001       +1     
==========================================
- Hits         7857     7743     -114     
- Misses        143      258     +115     
Flag Coverage Δ
DI 96.98% <11.11%> (-2.00%) ⬇️
DIT 96.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sunxd3
Copy link
Copy Markdown
Author

sunxd3 commented Apr 4, 2026

I think I understand the CI error, there is something I need to patch on the Mooncake side, will come back to this

@gdalle gdalle marked this pull request as draft April 5, 2026 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant