CompatHelper: bump compat for Meshes to 0.56 for package test, (keep existing compat)#214
Conversation
b002c38 to
df11b64
Compare
Benchmark Results (Julia v1.10)Time benchmarks
Memory benchmarks
|
|
@juliohm, our tests fail with the update to Meshes.jl v0.56. What would be the equivalent to achieve the following under v0.56: MeshIntegrals.jl/test/combinations.jl Line 507 in 92def00 This was possible in pre-v0.55 version, but fails on v0.56 with: |
|
Hi @JoshuaLampert , you can use |
|
Thanks @juliohm. Just in the same moment you commented I replaced the access of the internal field by using the function call |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #214 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 19 19
Lines 191 191
=========================================
Hits 191 191 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Looks like this was the only instance 👍 |
This pull request changes the compat entry for the
Meshespackage from0.53, 0.54, 0.55to0.53, 0.54, 0.55, 0.56for package test.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.