Skip to content

fix: sample_nbrs without replacement#648

Merged
CarloLucibello merged 2 commits intoJuliaGraphs:masterfrom
Parvm1102:fix-neighborloader-sampling-without-replacement
Mar 21, 2026
Merged

fix: sample_nbrs without replacement#648
CarloLucibello merged 2 commits intoJuliaGraphs:masterfrom
Parvm1102:fix-neighborloader-sampling-without-replacement

Conversation

@Parvm1102
Copy link
Copy Markdown
Contributor

Closes #646

I have replaced the rand() function with the StatsBase.sample() to prevent sampling with replacement.

Parvm1102 and others added 2 commits March 18, 2026 19:31
Signed-off-by: Parvm1102 <parvmittal31757@gmail.com>
@Parvm1102
Copy link
Copy Markdown
Contributor Author

The Docs check is failing, but I don't think it is related to the changed code, can you re-run this job @CarloLucibello ?

@Parvm1102
Copy link
Copy Markdown
Contributor Author

@CarloLucibello the tests are passing, the PR is ready for review.

@CarloLucibello CarloLucibello merged commit 5bcf181 into JuliaGraphs:master Mar 21, 2026
15 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sample_nbrs should do sampling without replacement

2 participants