Fix/remove self loops adjmat mutation#659
Merged
CarloLucibello merged 2 commits intoJuliaGraphs:masterfrom Mar 29, 2026
Merged
Conversation
Contributor
Author
|
@CarloLucibello , the GNNLux checks are failing, they were also failing in the last few open prs. |
Contributor
Author
in #626 , there was a compat added for GNNLux: [compat]
LuxTestUtils = "1"However it was removed in a later pr, we may enable it again or we may also explicitly skip AutoMooncake() here: |
Member
yes we could skip Mooncake for those tests that are failing at the moment. thanks for looking into it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #658
Now the graph will be copied so that it does not mutate the original graph in place.
I have also added tests for remove_self_loops for dense graph as well