Skip to content

Fix/remove self loops adjmat mutation#659

Merged
CarloLucibello merged 2 commits intoJuliaGraphs:masterfrom
Parvm1102:fix/remove-self-loops-adjmat-mutation
Mar 29, 2026
Merged

Fix/remove self loops adjmat mutation#659
CarloLucibello merged 2 commits intoJuliaGraphs:masterfrom
Parvm1102:fix/remove-self-loops-adjmat-mutation

Conversation

@Parvm1102
Copy link
Copy Markdown
Contributor

closes #658

Now the graph will be copied so that it does not mutate the original graph in place.

I have also added tests for remove_self_loops for dense graph as well

@Parvm1102
Copy link
Copy Markdown
Contributor Author

@CarloLucibello , the GNNLux checks are failing, they were also failing in the last few open prs.
I think it is related to some recent upstream changes thats triggering Automooncake() tests.

@Parvm1102
Copy link
Copy Markdown
Contributor Author

Parvm1102 commented Mar 29, 2026

@CarloLucibello , the GNNLux checks are failing, they were also failing in the last few open prs.
I think it is related to some recent upstream changes thats triggering Automooncake() tests.

in #626 ,

there was a compat added for GNNLux:

[compat]
LuxTestUtils = "1"

However it was removed in a later pr, we may enable it again or we may also explicitly skip AutoMooncake() here:

test_gradients(loss, x, ps; atol, rtol, skip_backends=[AutoForwardDiff(), AutoEnzyme()])

@CarloLucibello CarloLucibello merged commit 48c1528 into JuliaGraphs:master Mar 29, 2026
6 of 10 checks passed
@CarloLucibello
Copy link
Copy Markdown
Member

we may enable it again or we may also explicitly skip AutoMooncake() here:

yes we could skip Mooncake for those tests that are failing at the moment. thanks for looking into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove_self_loops mutates dense/sparse GNNGraph inputs in place

2 participants