Skip to content

Fix: GNNLux mooncake skip#665

Open
Parvm1102 wants to merge 2 commits intoJuliaGraphs:masterfrom
Parvm1102:fix/gnnlux-mooncake-skip
Open

Fix: GNNLux mooncake skip#665
Parvm1102 wants to merge 2 commits intoJuliaGraphs:masterfrom
Parvm1102:fix/gnnlux-mooncake-skip

Conversation

@Parvm1102
Copy link
Copy Markdown
Contributor

Recently, the GNNLux tests were failing in the CI because the newer version LuxTestUtils v2.3.0 was also checking for AutoMooncake() AD. Most of the layers in GNNLux are not compatible with mooncake. I skipped mooncake for those layers.

@Parvm1102
Copy link
Copy Markdown
Contributor Author

The layers incompatible with Mooncake in GNNLux:

  • Basic: GNNChain
  • Conv: GCNConv, ChebConv, GraphConv, AGNNconv, EdgeConv, DConv, GATConv, GATv2Conv, SGConv, GatedGraphConv, GINConv, NNConv, ResGatedGraphConv and SAGEConv.
  • Pool: GlobalAttentionPool
  • temporalconv: All layers failed

@Parvm1102 Parvm1102 marked this pull request as draft April 4, 2026 18:08
@Parvm1102
Copy link
Copy Markdown
Contributor Author

Parvm1102 commented Apr 4, 2026

@CarloLucibello , Now the GNN / julia 1 test is failing even though nothing is changed in the codebase, the error is as same as the one on GNNLux failure.
This is unexpected because the same test was passing on the last pr. I am currently investigating the issue.

@Parvm1102
Copy link
Copy Markdown
Contributor Author

@CarloLucibello , I tried to find the cause of GNN / julia 1 test failing.
This issue is most likely related to Mooncake v0.5.25 which was released 3 days ago. The PRs were passing tests before that.

It fails with:
MethodError: no method matching zero(::Mooncake.FriendlyTangentCache{Mooncake.AsRaw, Nothing})

The failure is not layer specific. It is related to how the friendly-tangent is changed in v0.5.25. might be related to.
should I try reporting to Mooncake.jl? What should be done with the failing tests as of now?

@Parvm1102 Parvm1102 marked this pull request as ready for review April 5, 2026 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant