Discourage convert(Array{C}, img) in favor of broadcasting#153
Merged
Discourage convert(Array{C}, img) in favor of broadcasting#153
convert(Array{C}, img) in favor of broadcasting#153Conversation
Member
Author
|
Several of these were not problematic in their original form, but my thought is that we should discourage anything that might encourage users to use Do you think we need to have a docs warning that |
Member
We can add it in #146. @mgautam98 do you want to continue that PR recently? |
Collaborator
Yes, I want to continue. I will add this warning. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consistent with JuliaImages/ImageCore.jl#131