Change isassigned() to match the Base definition#32
Open
JamesWrigley wants to merge 1 commit intoJuliaLang:mainfrom
Open
Change isassigned() to match the Base definition#32JamesWrigley wants to merge 1 commit intoJuliaLang:mainfrom
isassigned() to match the Base definition#32JamesWrigley wants to merge 1 commit intoJuliaLang:mainfrom
Conversation
ScopedValues.jl previously used `isassigned()` to check if a `ScopedValue` had a default value, but this differs from Base which uses `isassigned()` to check if a `ScopedValue` is initialized in the current scope.
Member
Author
|
(bump) |
1 similar comment
Member
Author
|
(bump) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ScopedValues.jl previously used
isassigned()to check if aScopedValuehad a default value, but that differs from Base which usesisassigned()to check if aScopedValueis initialized in the current scope.Fixes this behaviour:
This is technically a breaking change, but I would consider it a bugfix to match Base. It came up in the wild when using ScopedValues.jl in DistributedNext (JuliaParallel/DistributedNext.jl#17).