Backend based AbstractNFFT implementation#149
Merged
Merged
Conversation
This was referenced Sep 1, 2025
nHackel
referenced
this pull request
in MagneticResonanceImaging/MRIReco.jl
Nov 10, 2025
* Adapt to NFFT backend changes * Remove further symmetrize keyword * Remove explicit precompute pass since those are handled by NFFTOp (again) * Increase MRIOperators version to 0.4 * Bump MRIBase from 0.4.5 to 0.4.6 * Bump MRIReco from 0.9.0 to 0.9.1 * Bump MRISimulation from 0.1.3 to 0.1.4 * Capture additional keyword arguments s.t. they are not passed to NFFTOp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in here, it is currently not possible to use the
plan_nfftinterface when multiple packages such as NFFT and NonuniformFFTs are loaded in the same session. The underlying issue is that both packages refer to the same function and usually have no dedicated type to dispatch one, as both want to dispatch on "normal" user array types.This PR adds a "backend"-based selection of the NFFT plan implementation, which allows a user to chose which backend to use for a given
plan_nfftcall. This utilizes an additional first parameter which specifies the backend to use:To hide this additional type from the users of upstream packages, AbstractNFFTs now features an active backend global constant, similar to how Makie allows one to switch between its backends:
This PR allows upstream packages such as LinearOperatorCollection (PR) or MRIOperators to define themselves in terms of AbstractNFFTs and use exchangable NFFT providers.