Skip to content

Update solver_specific example due to failure#155

Merged
tmigot merged 4 commits into
JuliaSmoothOptimizers:mainfrom
arnavk23:main
May 26, 2026
Merged

Update solver_specific example due to failure#155
tmigot merged 4 commits into
JuliaSmoothOptimizers:mainfrom
arnavk23:main

Conversation

@arnavk23
Copy link
Copy Markdown
Contributor

@arnavk23 arnavk23 commented May 21, 2026

@tmigot The rendering failure was caused by the newly added example in the solver_specific section: calling bmark_solvers in this environment triggers UndefVarError: reset! during weaving, which then broke the generated page content. I reproduced this locally from the same weave/parse pipeline and confirmed the failing error block in index.md:560

Copilot AI review requested due to automatic review settings May 21, 2026 15:23
@arnavk23 arnavk23 changed the title changing example due to failure Update solver_specific example due to failure May 21, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates the tutorial example for solver-specific statistics to use a minimal ADNLPModels-based setup instead of running a full benchmark over NLPModelsTest problems.

Changes:

  • Replaced the benchmark-based example (bmark_solvers, NLPModelsTest.BROWNDEN()) with a simple ADNLPModel and direct GenericExecutionStats usage.
  • Removed DataFrames/NLPModelsTest/SolverBenchmark imports from the example snippet.
  • Updated the demonstration output to show stats.solver_specific directly.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tutorials/introduction-to-solverbenchmark/index.jmd Outdated
Comment thread tutorials/introduction-to-solverbenchmark/index.jmd
Comment thread tutorials/introduction-to-solverbenchmark/index.jmd Outdated
@tmigot
Copy link
Copy Markdown
Member

tmigot commented May 23, 2026

This is a SolverBenchmark documentation, so I don't understand how removing this package will help?

@arnavk23
Copy link
Copy Markdown
Contributor Author

This is what we should be looking at

[ Info: running solver newton
[ Info:          Solver             Name    nvar    ncon           status    iter      Time      f(x)      Dual    Primal  
[ Info:          newton  BROWNDEN_manual       4       0          unknown      -1       Inf       Inf       Inf   0.0e+00
1-element Vector{Union{Missing, Bool}}:
 1

But currently we see

Error: UndefVarError: `reset!` not defined in `SolverBenchmark`
Hint: It looks like two or more modules export different bindings with this name, resulting in ambiguity. Try explicitly importing it from a particular module, or qualifying the name with the module i
t should come from.
Hint: a global variable of this name also exists in DataStructures.
Hint: a global variable of this name also exists in SolverCore.
Hint: a global variable of this name also exists in WorkerUtilities.
Hint: a global variable of this name also exists in ConcurrentUtilities.
Hint: a global variable of this name also exists in LinearOperators.
    - Also exported by NLPModels (loaded but not imported in Main).

@arnavk23
Copy link
Copy Markdown
Contributor Author

This is a SolverBenchmark documentation, so I don't understand how removing this package will help?

I agree with your comment here and think the example is solid so just added for the reset! to pass. Why make a big change when the example we agreed on gives everything a user needs to go through the function implementation.

@tmigot tmigot merged commit 7d1801e into JuliaSmoothOptimizers:main May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants