Update solver_specific example due to failure#155
Conversation
solver_specific example due to failure
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the tutorial example for solver-specific statistics to use a minimal ADNLPModels-based setup instead of running a full benchmark over NLPModelsTest problems.
Changes:
- Replaced the benchmark-based example (
bmark_solvers,NLPModelsTest.BROWNDEN()) with a simpleADNLPModeland directGenericExecutionStatsusage. - Removed DataFrames/NLPModelsTest/SolverBenchmark imports from the example snippet.
- Updated the demonstration output to show
stats.solver_specificdirectly.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This is a SolverBenchmark documentation, so I don't understand how removing this package will help? |
|
This is what we should be looking at But currently we see |
I agree with your comment here and think the example is solid so just added for the reset! to pass. Why make a big change when the example we agreed on gives everything a user needs to go through the function implementation. |
@tmigot The rendering failure was caused by the newly added example in the solver_specific section: calling bmark_solvers in this environment triggers
UndefVarError: reset!during weaving, which then broke the generated page content. I reproduced this locally from the same weave/parse pipeline and confirmed the failing error block inindex.md:560