-
Notifications
You must be signed in to change notification settings - Fork 37
[backport] Add availability flags in NLPModelMeta and NLSMeta #525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 0.21.x
Are you sure you want to change the base?
Conversation
tmigot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, the implementation of NLPModels should set one of this flag to false is something is not implemented. We should also document it somewhere, if no obvious place in the NLPModels doc maybe the docstrings of the function to implement.
What is the motivation for this? Is that automatic solver selection ?
In ADNLPModels, it can even be automatic by checking whether EmptyADBackend is mentioned.
|
@tmigot The motivation is here: #524 (comment) |
|
The main issue is that is more models than before can't implement all the API (NN models, Oracle in MOI) and the solvers like |
Too much specific, we don't want to have The idea of |
|
Filling the attributes in the meta can be handled differently by the different implementation of nlpmodels. For most, it will be manually put, but ADNLPModels ca ba automatic. It does not add dependencies to adnlpmodels later on. |
|
Yes, I agree. |
I think it should be in the docstrings of the function, users will know that |
If you don't do it in this PR, please open an issue about it, thanks! |
Similar to #524 but for the branch
0.21.xwhich allows backporting some commits.We can also check that we don't break anything, the breakage workflow should work here.