Parse Cmd's to identify names interpolated in#161
Draft
ericphanson wants to merge 5 commits intomainfrom
Draft
Conversation
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com>
Replace manual $-scanning for cmdstrings with a single Meta.parse + Base.shell_parse pass to extract interpolated expressions, and dedupe per cmdstring node. This aligns with Julia’s cmd parsing rules and removes brittle string handling in get_names_used. Co-authored-by: Codex codex@openai.com (codex@openai.com)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not really sure we want this, it's a lot of code to handle this edge case.. but I wanted to see what codex 5.2 could do for #81