Skip to content

Fix IOBuffer data race in stdio_loop / take! #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
giordano merged 1 commit into from
Mar 26, 2026
Merged

Fix IOBuffer data race in stdio_loop / take! #120

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions src/ParallelTestRunner.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,17 @@ const ID_COUNTER = Threads.Atomic{Int}(0)
struct PTRWorker <: Malt.AbstractWorker
w::Malt.Worker
io::IOBuffer
io_lock::ReentrantLock
id::Int
end

function PTRWorker(; exename=Base.julia_cmd()[1], exeflags=String[], env=String[])
io = IOBuffer()
io_lock = ReentrantLock()
wrkr = Malt.Worker(; exename, exeflags, env, monitor_stdout=false, monitor_stderr=false)
stdio_loop(wrkr, io)
stdio_loop(wrkr, io, io_lock)
id = ID_COUNTER[] += 1
return PTRWorker(wrkr, io, id)
return PTRWorker(wrkr, io, io_lock, id)
end

worker_id(wrkr::PTRWorker) = wrkr.id
Expand Down Expand Up @@ -258,19 +260,19 @@ function print_test_crashed(wrkr, test, ctx::TestIOContext)
end

# Adapted from `Malt._stdio_loop`
function stdio_loop(worker::Malt.Worker, io)
function stdio_loop(worker::Malt.Worker, io, io_lock::ReentrantLock)
Threads.@spawn while !eof(worker.stdout) && Malt.isrunning(worker)
try
bytes = readavailable(worker.stdout)
write(io, bytes)
@lock io_lock write(io, bytes)
catch
break
end
end
Threads.@spawn while !eof(worker.stderr) && Malt.isrunning(worker)
try
bytes = readavailable(worker.stderr)
write(io, bytes)
@lock io_lock write(io, bytes)
catch
break
end
Expand Down Expand Up @@ -1061,7 +1063,7 @@ function runtests(mod::Module, args::ParsedArgs;
ex
end
test_t1 = time()
output = String(take!(wrkr.io))
output = @lock wrkr.io_lock String(take!(wrkr.io))
push!(results, (test, result, output, test_t0, test_t1))

# act on the results
Expand Down
Loading