feat(server): spawn task sooner in listenloop + fast accept#1103
Draft
pankgeorg wants to merge 4 commits intoJuliaWeb:masterfrom
Draft
feat(server): spawn task sooner in listenloop + fast accept#1103pankgeorg wants to merge 4 commits intoJuliaWeb:masterfrom
pankgeorg wants to merge 4 commits intoJuliaWeb:masterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1103 +/- ##
==========================================
+ Coverage 82.34% 82.38% +0.04%
==========================================
Files 32 33 +1
Lines 3042 3089 +47
==========================================
+ Hits 2505 2545 +40
- Misses 537 544 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So, this is a bit speculative, but I'm very very concerned about the backlog getting big; I think it's always a good idea to get through as many accepts as possible, before spawning the tasks to handle the connections. This builds on #1102 and adds a
acceptmanyfunction that returns a vector of accepted connections, if they are available.I've run some benchmarks (this commit) on this and it seems that it helps for the benchmarks that are connection intensive:
see latency-average for plaintext and json (the db related queries also benefit from async query send)