Skip to content

Conversation

@kbondarev
Copy link
Collaborator

Closes #72

Still need to manually merge the people files prefixed with double underscore "__" and make just one file per host/guest.

@gerbrent
Copy link
Collaborator

Safe to merge this to store the work done, then I can get to choosing the correct profiles later?

Wondering if that's the best course of action......

@kbondarev
Copy link
Collaborator Author

@gerbrent This is how I'd go about this:

  • Checkout this branch, commit your changes to it and push to github.
  • Then will have to resolve any conflicts with the main branch (I could deal with that if you want)
  • Then when all ready, move this PR from draft to ready

In practice it looks like this:

  • Change to the branch
git checkout feature/people-data-conflict
  • Just in case you've been on it before locally, pull so it's all up to date:
git pull
  • Do any work - make whatever commits you want locally and then push them. You will see them appear here in this PR.

Message me on Matrix if you got any questions or need help:)

@gerbrent
Copy link
Collaborator

gerbrent commented Jul 12, 2022

Oh this is a brilliant way to work on this. new paradigm engaged
Thanks @kbondarev !

@ironicbadger
Copy link
Collaborator

A lot has happened since this PR was opened.At a minimum it needs rebasing before a merge, but is it still something we want?

@gerbrent
Copy link
Collaborator

definitely my fault on the stagnation - i was supposed to take action here.

@ironicbadger
Copy link
Collaborator

The people file for me needs to match what I PR'd earlier imho.

@gerbrent
Copy link
Collaborator

gerbrent commented Sep 2, 2022

I am actively working on this today - merging all the duplicate profiles.

@gerbrent gerbrent added in progress currently being worked on low priority ... but not necessarily unimportant labels Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in progress currently being worked on low priority ... but not necessarily unimportant

Projects

None yet

Development

Successfully merging this pull request may close these issues.

scraper - possible non-identical guest/host pages from various shows?

4 participants