Skip to content

Fix some type hints (EndianBinaryReader, EndianBinaryWriter)#293

Merged
K0lb3 merged 3 commits intoK0lb3:masterfrom
isHarryh:patch
Feb 4, 2025
Merged

Fix some type hints (EndianBinaryReader, EndianBinaryWriter)#293
K0lb3 merged 3 commits intoK0lb3:masterfrom
isHarryh:patch

Conversation

@isHarryh
Copy link
Copy Markdown
Contributor

@isHarryh isHarryh commented Jan 30, 2025

Summary

This PR mainly fixes some type hints in EndianBinaryReader and EndianBinaryWriter.

By the way, some minor code issues are fixed, including:

  1. Legacy code lines (e.g. legacy pass statement) are removed.
  2. Some imports and isinstance-checks are optimized.
  3. Some potential errors (e.g. int conversion) are fixed.

For more details, please refer to the commits.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants