Skip to content

Add test runner workflow#1020

Open
stevemessick wants to merge 5 commits into
mainfrom
test-run
Open

Add test runner workflow#1020
stevemessick wants to merge 5 commits into
mainfrom
test-run

Conversation

@stevemessick
Copy link
Copy Markdown
Contributor

@stevemessick stevemessick commented May 21, 2026

Adds a workflow to run tests on commit.
Fixes #1009
Fixes #1015

@stevemessick stevemessick requested a review from rosbo May 21, 2026 21:53
@@ -0,0 +1,37 @@
name: presubmit
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All our CI/CD stuff is setup to use Google Cloud Build. We should stick with that rather than using GitHub workflow.

Can you add simply add a new "test step" after the existing step we already run on every PR:

- name: us-docker.pkg.dev/$PROJECT_ID/tools/cli-builder:${_PYTHON_VERSION}
id: lint
args:
- run
- lint:all
waitFor: ['build-hatch-image']

Comment thread src/kaggle/cli.py
return shared


def _get_shared_competition_topics_parser() -> argparse.ArgumentParser:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make sure your PR only includes related changes. i.e. the changes to setup the test runner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

competitions topics always return a 403 error OAuth authentication fails after kaggle config set creates kaggle.json

2 participants