feat(e2e) add data testid attributes#217
Open
nomadbitcoin wants to merge 4 commits intomainfrom
Open
Conversation
Add data-testid attributes to all interactive components across navigation, wallet modal, bidders, candidates, members, payouts pages, and transaction feedback toasts to enable reliable E2E test element selection.
- Replace data-testid with data-test convention (cypress-realworld-app) - Use type extensions instead of custom test props on components - Rename abbreviated selectors (btn → button) for discoverability - Add cy.getBySel() and cy.getBySelLike() Cypress custom commands
- Break long line in BidVouch submit button - Remove unused htmlProps destructuring in TimeRemaining
✅ Deploy Preview for dreamy-gates-ad44c0 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added data-testid attributes to all interactive components so E2E tests can reliably select elements regardless of styling changes.
All review comments from PR #204 have been addressed.