Open
Conversation
Mychecksdead
reviewed
Feb 9, 2025
Member
There was a problem hiding this comment.
Since the AnkleConstants.maxAngle and minAngle are in the type of encoder (not encoder_value * gearRatio), there seems to be a bug in setAngle and setAngleTest. I think we should pass directly the angle value to the closedLoopController.setReference and set the gearRatio in the constructor of the Subsystem class instead of multiplying every time.
Mychecksdead
reviewed
Feb 9, 2025
exeokan
requested changes
Feb 10, 2025
src/main/java/frc/robot/subsystems/AnkleSubsystem/AnkleSubsystem.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/robot/subsystems/AnkleSubsystem/AnkleSubsystem.java
Outdated
Show resolved
Hide resolved
|
|
||
| } | ||
|
|
||
| public void setSparkPIDControllerToDashboard(String prefix, double kP, double kI, double kD, double kMinOutput, |
There was a problem hiding this comment.
do we really need a class for this? how about we set up a smart dashboard handler class that has all the set/get methods regarding all subsystems
Member
Author
There was a problem hiding this comment.
could you more clarify? we didnt understand ( w/mychecksdead)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ankle subsystem added. It contains basic level functions.