fix: #1509 column visibility toggle disabled state for header groups#1510
Open
miraajkadam wants to merge 1 commit intoKevinVandy:v3from
Open
fix: #1509 column visibility toggle disabled state for header groups#1510miraajkadam wants to merge 1 commit intoKevinVandy:v3from
miraajkadam wants to merge 1 commit intoKevinVandy:v3from
Conversation
|
@miraajkadam is attempting to deploy a commit to the Kevin Vandy OSS Team on Vercel. A member of the Team first needs to authorize it. |
miraajkadam
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the disabled state relied solely on
!column.getCanHide()from the TanStack Table API. While this works for leaf columns, it does not correctly represent the disabled state for header groups with child columns that haveenabledHiding: false.This change adds a dedicated function to compute the disabled state for grouped columns by considering the visibility and
enableHidingconfiguration of their child columns.Fixes: #1509