feat(detection): support Codex Reasoning Level numbered prompt (#616)#617
Merged
feat(detection): support Codex Reasoning Level numbered prompt (#616)#617
Conversation
…rompt with submitMode
- Add SubmitMode type ('answer_only' | 'answer_then_enter') to MultipleChoicePromptData
- Extend CONFIRMATION_FOOTER_PATTERN to detect "press number to confirm" footer
- Derive submitMode from footer pattern in detectMultipleChoicePrompt()
- Add submitMode-aware Enter suppression in sendPromptAnswer() with fail-safe fallback
- Include submitMode in buildPromptResponseBody() for client-server propagation
- Delegate respond/route.ts to sendPromptAnswer() (remove direct sendKeys)
- Add fallbackSubmitMode support in prompt-response/route.ts with allowlist validation
- All 6052 unit tests pass, 0 lint/type errors
Resolves #616
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…cation - Extract isValidSubmitMode type guard to src/types/models.ts for shared allowlist validation (was duplicated in prompt-answer-sender and route) - Extract resolveSubmitMode and shouldSuppressEnter helpers in prompt-answer-sender.ts for clearer intent and testability - Combine two scanWindow iterations into single-pass footer detection in prompt-detect-multiple-choice.ts to avoid redundant iteration Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This was referenced Apr 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
multiple_choicepromptとして正しく検出できるようprompt-detect-multiple-choice.tsを拡張SubmitMode型（answer_only/answer_then_enter）をmodels.tsに追加し、Codex numbered promptの入力契約を明示的にモデル化respond/route.tsとprompt-response/route.tsでsubmitModeに応じた送信制御を実装Closes #616
Test plan
npm run lint— PASSnpx tsc --noEmit— PASSnpm run test:unit— 6052 passednpm run build— PASS🤖 Generated with Claude Code