Skip to content

fix(detection): detect Codex /model selection as selection list instead of multiple_choice (#622)#623

Merged
Kewton merged 1 commit intodevelopfrom
fix/622-codex-model-selection-list
Apr 4, 2026
Merged

fix(detection): detect Codex /model selection as selection list instead of multiple_choice (#622)#623
Kewton merged 1 commit intodevelopfrom
fix/622-codex-model-selection-list

Conversation

@Kewton
Copy link
Copy Markdown
Owner

@Kewton Kewton commented Apr 4, 2026

Summary

  • Codex /model の Step 1(モデル選択)と Step 2(Reasoning Level)の Press enter to select/confirm footer を CODEX_SELECTION_LIST_PATTERN に追加
  • status-detector.ts で Codex Enter確定型UIを selection list として検出(waiting/codex_selection_list
  • prompt-detect-multiple-choice.ts で Codex Enter確定型footerを持つ画面を multiple_choice 検出から除外
  • これにより NavigationButtons(矢印+Enter)で操作可能になり、Reasoning Level画面がスキップされなくなる
  • 5テストケース追加(Step 1/Step 2 selection list検出、prompt除外、Issue #616回帰確認)

Closes #622

Test plan

  • npm run lint — PASS
  • npx tsc --noEmit — PASS
  • npm run test:unit — 6106 passed
  • npm run build — PASS

🤖 Generated with Claude Code

Expand CODEX_SELECTION_LIST_PATTERN to match "press enter to select"
in addition to "press enter to confirm", and move Codex selection list
detection before detectPrompt to prevent false multiple_choice detection.

- Expand regex: /press\s+enter\s+to\s+confirm/i -> /press\s+enter\s+to\s+(?:confirm|select)/i
- Add priority 0.8 early-check for Codex selection list (mirrors Copilot pattern)
- Remove old A2 check in Codex TUI block (replaced by early-check)
- Add tests for Step 1 (model selection) and Step 2 (reasoning level)
- Verify "press number to confirm" (Issue #616) is not affected

Resolves #622

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@Kewton Kewton merged commit fac3509 into develop Apr 4, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant