Conversation
Expand CODEX_SELECTION_LIST_PATTERN to match "press enter to select" in addition to "press enter to confirm", and move Codex selection list detection before detectPrompt to prevent false multiple_choice detection. - Expand regex: /press\s+enter\s+to\s+confirm/i -> /press\s+enter\s+to\s+(?:confirm|select)/i - Add priority 0.8 early-check for Codex selection list (mirrors Copilot pattern) - Remove old A2 check in Codex TUI block (replaced by early-check) - Add tests for Step 1 (model selection) and Step 2 (reasoning level) - Verify "press number to confirm" (Issue #616) is not affected Resolves #622 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/modelの Step 1(モデル選択)と Step 2(Reasoning Level)のPress enter to select/confirmfooter をCODEX_SELECTION_LIST_PATTERNに追加status-detector.tsで Codex Enter確定型UIを selection list として検出(waiting/codex_selection_list)prompt-detect-multiple-choice.tsで Codex Enter確定型footerを持つ画面を multiple_choice 検出から除外Closes #622
Test plan
npm run lint— PASSnpx tsc --noEmit— PASSnpm run test:unit— 6106 passednpm run build— PASS🤖 Generated with Claude Code